Skip to content

fix: improve platform-dependent command execution in grunt tasks #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bartvanandel
Copy link

Fixes #2010

@bartvanandel bartvanandel force-pushed the fix/2010_npm_install_fails_on_macos branch from 7e564a9 to d1a2b8a Compare April 8, 2025 15:26
@bartvanandel bartvanandel marked this pull request as draft April 8, 2025 16:12
@bartvanandel bartvanandel force-pushed the fix/2010_npm_install_fails_on_macos branch from d1a2b8a to b7e7f33 Compare April 8, 2025 16:27
Use lazy, memoized getter to prevent unnecessary execution of `sed`
every time the Gruntfile.js file is loaded.
@bartvanandel bartvanandel force-pushed the fix/2010_npm_install_fails_on_macos branch from b7e7f33 to eef1d5d Compare April 8, 2025 16:34
@bartvanandel bartvanandel marked this pull request as ready for review April 8, 2025 16:35
@bartvanandel
Copy link
Author

Note to maintainers: I noticed that glob isn't installed as a direct dev dependency, but is being imported in Gruntfile.js. You may want to address that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: npm install fails at exec:fixCryptoApiImports on MacOS when sed is GNU sed
1 participant