added new optional configurable organisation and state fields for ent… #1892
+2,380
−5,405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PE39806
changed the title
JR40159
requested changes
Feb 11, 2025
| export async function up() { | ||
| await ModelModel.updateMany({ organisation: { $exists: false } }, { $set: { organisation: '' } }) | ||
| await ModelModel.updateMany({ state: { $exists: false } }, { $set: { state: '' } }) | ||
| // for (const model of models) { |
| kind: z.nativeEnum(EntryKind).optional().openapi({ example: EntryKind.Model }), | ||
| organisation: z.string().optional().openapi({ example: 'My Organisation' }), |
There was a problem hiding this comment.
Is there any way our API docs could use the config to display the possible organisation options?
There was a problem hiding this comment.
Also this implementation does mean that the options for both are only enforced/available via the UI not the API or python client? Enforcing that the user is always restricted to a set of options for both will ensure consistency
PE39806
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ries