Merge pull request ceph#334 from leonidc/issue_284

create_subsystem should fail if --enable-ha=true, and --ana-reporting…
gbregman · Nov 22, 2023 · 2acfd4a · 2acfd4a
2 parents be63c22 + 81958f1
commit 2acfd4a
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/control/grpc.py b/control/grpc.py
@@ -308,6 +308,8 @@ def create_subsystem_safe(self, request, context=None):
 
         if self.is_discovery_nqn(request.subsystem_nqn):
             raise Exception(f"Can't create a discovery subsystem")
+        if request.enable_ha == True  and request.ana_reporting == False:
+            raise Exception(f"Validation Error: HA enabled but ANA-reporting is disabled ")
 
         min_cntlid = self.config.getint_with_default("gateway", "min_controller_id", 1)
         max_cntlid = self.config.getint_with_default("gateway", "max_controller_id", 65519)