lab/niriss fixes #182
lab/niriss fixes #182
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -3073,7 +3073,7 @@ def load_GroupFLT(field_root='j142724+334246', PREP_PATH='../Prep', force_ref=No | |||
| for filt in ['F090W', 'F115W', 'F150W', 'F200W']: | |||
| #key = f'{gr.lower()}-{filt.lower()}' | |||
| # key = filt.lower() | |||
| key = filt.lower() + 'n-clear' | |||
| key = filt.lower() + '-clear' | |||
There was a problem hiding this comment.
For some reason this also works with key = filt.lower() and I can't understand why this works as well.
grizli/pipeline/auto_script.py
Outdated
| @@ -4572,7 +4572,8 @@ def make_filter_combinations(root, weight_fnu=2, filter_combinations=FILTER_COMB | |||
| head[band] = im_i[0].header.copy() | |||
| else: | |||
| for k in im_i[0].header: | |||
| head[band][k] = im_i[0].header[k] | |||
| #head[band][k] = im_i[0].header[k] | |||
There was a problem hiding this comment.
You can also just skip the offending keys:
if k == '' or k == 'HISTORY': continue
There was a problem hiding this comment.
sounds good, I can change that
|
Note: grizli/grizli/aws/visit_processor.py Line 2192 in 3b3f09d |
|
Adding that |
|
And for the background image, maybe you can rather write the updated version to the working directory and update the returned |
|
Thanks - Raphael and I are looking into this |
|
Is this PR now superseded by the others @TheSkyentist submitted today? |
|
I believe so but I'll let @lboogaard be the final decider. The "n-clear" issue still exists (see #191) though I don't think this PR presents a global solution for combined NIRCam/NIRISS data. |
Dear Gabe,
Here is a long overdue PR with some fixes needed to run NIRISS data
n-cleartoclearbecause it won't work otherwiseFYI: @jdavies-st @rameyer @TheSkyentist