Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate deg/rad conversions and bins creation in code #1281

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Mar 3, 2025

This is just a refactoring PR (no bug and no feature) and hopefully improved the consistency and readability of the code.

Some numpy functions need radians and these were calculated in different ways. This PR consolidates them to the usage of deg2rad and rad2deg. The second commit suggests a more descriptive creation of bins.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (29c06c0) to head (90fb095).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1281   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          24       24           
  Lines        2383     2383           
=======================================
  Hits         2346     2346           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gboeing
Copy link
Owner

gboeing commented Mar 5, 2025

Thanks!

@gboeing gboeing merged commit 844dd79 into gboeing:main Mar 5, 2025
6 checks passed
@eumiro eumiro deleted the consolidate-numpy branch March 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants