Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #1661

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Increase test coverage #1661

merged 1 commit into from
Feb 16, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Feb 16, 2025

  • When a condition should never occur because the developers should ensure that it never can, use assume or _unreachable, not fatalerror
  • File did not need an explicit close method with an uncovered return nullptr;
  • Cover all of tryConstAnd

@Rangi42 Rangi42 added the refactoring This PR is intended to clean up code more than change functionality label Feb 16, 2025
@Rangi42 Rangi42 added this to the 0.9.2 milestone Feb 16, 2025
@Rangi42 Rangi42 merged commit c9060c7 into gbdev:master Feb 16, 2025
23 checks passed
@Rangi42 Rangi42 deleted the more-coverage branch February 16, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This PR is intended to clean up code more than change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant