Derive operator!= from operator== (stops supporting gcc 9.x)
#1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1659.
gcc started supporting
operator!=derived fromoperator==in version 10.1 (released May 2020). Version 9 (up to 9.5, released May 2022) did not.Ubuntu 20.04 LTS came with gcc 9.3 (released March 2020) by default. Since then, there have been two more LTS releases, 22.04 and 24.04. We were testing and building on 20.04 in CI "for best glibc compatibility", but with two newer LTS releases to choose from, that can be dropped. (See this Discord conversation.)