Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expectations about auto-inertial warnings #1520

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

scpeters
Copy link
Member

Targeting #1513.

This updates expectations for three test cases related to auto-inertial warnings by using the ERR enforcement policy in ParserConfig:

  • ResolveAutoInertialsWithDifferentDensity: parse first with enforcement policy ERR and expect a warning about unset collision density. Keep the subsequent parsing with default enforcement policy that expects no errors but will print the warning to the console.
  • InertialValuesGivenWithAutoSetToTrue: parse first with enforcement policy ERR and expect a warning about user-specified inertial values. Again keep the subsequent parsing with default enforcement policy that expects no errors but will print the warning to the console.
  • ResolveAutoInertialsWithMassAndDefaultDensity: remove the user-specified //inertial/pose and //inertial/inertia values, parse with enforcement policy ERR and expect no warnings/errors.

@scpeters scpeters requested a review from azeey as a code owner December 20, 2024 21:23
@scpeters scpeters requested review from iche033 and removed request for azeey December 20, 2024 21:23
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@iche033 iche033 merged commit fa5d367 into auto_inertia_mass Dec 20, 2024
9 checks passed
@iche033 iche033 deleted the scpeters/auto_inertia_mass_warnings branch December 20, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants