Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel CI #1500

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Bazel CI #1500

merged 7 commits into from
Nov 12, 2024

Conversation

shameekganguly
Copy link
Contributor

🎉 New feature

Summary

Adds CI for bazel build and tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mjcarroll and others added 5 commits November 4, 2024 15:49
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 12, 2024
@shameekganguly shameekganguly changed the base branch from sdf15 to mjcarroll/bzlmod November 12, 2024 20:10
Signed-off-by: Shameek Ganguly <[email protected]>
@shameekganguly shameekganguly changed the base branch from mjcarroll/bzlmod to sdf15 November 12, 2024 20:14
@mjcarroll mjcarroll closed this Nov 12, 2024
@mjcarroll mjcarroll reopened this Nov 12, 2024
@scpeters
Copy link
Member

should we make any of these bazel CI builds required for sdf15 and main branches?

@mjcarroll
Copy link
Contributor

should we make any of these bazel CI builds required for sdf15 and main branches?

I don't have any strong reason not to. It would keep the bazel build files up-to-date. The CI runs pretty quickly and is unobtrusive for the most part. If something fails in bazel, it's probably also failing in other places.

@mjcarroll mjcarroll merged commit bddaf0d into sdf15 Nov 12, 2024
16 checks passed
@mjcarroll mjcarroll deleted the shameek/bzlmod branch November 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants