Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated APIs for Ionic #1456

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Remove deprecated APIs for Ionic #1456

merged 1 commit into from
Jul 9, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 8, 2024

🎉 New feature

Removes deprecated APIs

Summary

These APIs were deprecated in sdf13 or sdf14, so they can now be removed.

Test it

Build gz-sim9 and confirm that it compiles successfully.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Joint.hh: *LinkName setters and getters
* parser.hh: checkJointParentChildLinkNames(const sdf::Root *)
* SDFImpl.hh: Root(const ElementPtr)
* Types.hh: kSdfScopeDelimiter, SdfScopeDelimiter(), Inertia

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner July 8, 2024 22:49
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 8, 2024
@scpeters scpeters merged commit 1779253 into main Jul 9, 2024
12 checks passed
@scpeters scpeters deleted the scpeters/rm_deprecated branch July 9, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants