Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport mesh optimization feature #1395

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Backport mesh optimization feature #1395

merged 3 commits into from
Apr 10, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 8, 2024

➡️ Backport

Backport mesh optimization related changes from #1382 and #1386

Note to maintainers: Remember to Rebase and merge with commit (not squash-merge)

@iche033 iche033 requested review from azeey and scpeters as code owners April 8, 2024 17:49
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 8, 2024
@scpeters
Copy link
Member

these changes also need python bindings

@scpeters
Copy link
Member

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

I think rebase-and-merge works well for backports

@scpeters
Copy link
Member

these changes also need python bindings

ticketed in #1400

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you include a backport of the python bindings in #1398?

@scpeters
Copy link
Member

#1398

actually they were already added in #1398

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Apr 10, 2024

actually they were already added in #1398

updated PR to include commit from #1398

@iche033
Copy link
Contributor Author

iche033 commented Apr 10, 2024

I think rebase-and-merge works well for backports

Updated PR description

@iche033 iche033 merged commit 1c0bc30 into sdf14 Apr 10, 2024
10 checks passed
@iche033 iche033 deleted the mesh_optimization_14 branch April 10, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants