Code cleanup #578
Open
Code cleanup #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Derbasov <[email protected]>
ntfshard
force-pushed
the
codeCleanup
branch
from
a98ebb4 to
9f279e8
Compare
ahcorde
requested changes
Feb 17, 2025
include/gz/transport/Clock.hh
Outdated
| @@ -112,7 +112,7 @@ namespace gz | |||
| private: WallClock(); | |||
|
|
|||
| /// \brief Destructor | |||
| private: ~WallClock() override; | |||
| public: ~WallClock() override; | |||
There was a problem hiding this comment.
Why this change is required ?
There was a problem hiding this comment.
Her it's for consistency and to not break Liskov substitution principle
include/gz/transport/NodeShared.hh
Outdated
| @@ -301,7 +301,7 @@ namespace gz | |||
| protected: NodeShared(); | |||
|
|
|||
| /// \brief Destructor. | |||
| protected: virtual ~NodeShared(); | |||
| public: virtual ~NodeShared(); | |||
There was a problem hiding this comment.
Why this change is required ?
There was a problem hiding this comment.
This change left after splitting previous PR to memory leak fix part (will be published after this PR) and cleanup. I suppose it fits well to cleanup patch due to private destructor mostly making problems (in comparing with private ctor which make sense in some specific context). For example https://godbolt.org/z/61P3q553d
caguero
reviewed
Feb 18, 2025
Signed-off-by: Maksim Derbasov <[email protected]>
ntfshard
force-pushed
the
codeCleanup
branch
from
1ccf666 to
a91d48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
This PR should fix typos and simplify/cleanup C++ code.
Also adding missing library in docker file which requested by bench tool
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.