Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused MessagePublisherPrivate forward declaration (backport #570) #573

Open
wants to merge 2 commits into
base: ign-transport11
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 3, 2025

Summary

Removed an unused forward declaration.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #570 done by Mergify.

Signed-off-by: Carlos Agüero <[email protected]>
(cherry picked from commit 75b3f72)

# Conflicts:
#	include/gz/transport/Publisher.hh
@mergify mergify bot requested a review from caguero as a code owner February 3, 2025 18:12
@mergify mergify bot added the conflicts label Feb 3, 2025
Copy link
Contributor Author

mergify bot commented Feb 3, 2025

Cherry-pick of 75b3f72 has failed:

On branch mergify/bp/ign-transport11/pr-570
Your branch is up to date with 'origin/ign-transport11'.

You are currently cherry-picking commit 75b3f72.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/gz/transport/Publisher.hh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 3, 2025
Signed-off-by: Carlos Agüero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

1 participant