Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackedVehicle: Added docs for body_link option #2652

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Oct 14, 2024

🦟 Bug fix

Fixes #2650

Summary

This PR adds forgotten documentation for the <body_link> tag in TrackedVehicle system.

The docs refer to source code at https://github.com/gazebosim/gz-sim/blob/gz-sim9/src/systems/tracked_vehicle/TrackedVehicle.cc#L238 and https://github.com/gazebosim/gz-sim/blob/gz-sim9/src/systems/tracked_vehicle/TrackedVehicle.cc#L475 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde enabled auto-merge (squash) October 15, 2024 07:54
@ahcorde
Copy link
Contributor

ahcorde commented Oct 15, 2024

@osrf-jenkins run tests please!

@iche033
Copy link
Contributor

iche033 commented Oct 15, 2024

the Examples test failure should be fixed once #2649 is merged forward to main. The homebrew test failures are due to osrf/homebrew-simulation#2834. This PR should be safe to merge since it just adds a comment.

@iche033 iche033 disabled auto-merge October 15, 2024 19:01
@iche033 iche033 merged commit c0ecf8d into gazebosim:main Oct 15, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants