Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skybox in wide angle cam view #901

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 6, 2023

🎉 New feature

Summary

Add support for setting sky (background material with a skybox cubemap) in wide angle camera view.

This is needed for harmonic demo but more of a feature than a bugfix so can come after release. No API/ABI breakages

Test it

See gazebosim/harmonic_demo#7

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #901 (f2da8bb) into gz-rendering8 (c1af6fd) will increase coverage by 0.02%.
The diff coverage is 85.41%.

❗ Current head f2da8bb differs from pull request most recent head 864981d. Consider uploading reports for the commit 864981d to get more accurate results

@@                Coverage Diff                @@
##           gz-rendering8     #901      +/-   ##
=================================================
+ Coverage          75.14%   75.17%   +0.02%     
=================================================
  Files                177      177              
  Lines              16832    16879      +47     
=================================================
+ Hits               12649    12689      +40     
- Misses              4183     4190       +7     
Files Coverage Δ
ogre2/src/Ogre2Scene.cc 78.53% <83.33%> (+0.03%) ⬆️
ogre2/src/Ogre2WideAngleCamera.cc 85.41% <85.71%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

@azeey
Copy link
Contributor

azeey commented Sep 27, 2023

Let's hold off merging this till after the Harmonic release

@ahcorde ahcorde merged commit 22b2bbf into gz-rendering8 Oct 5, 2023
6 checks passed
@ahcorde ahcorde deleted the fix_wide_angle_cam_sky branch October 5, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants