Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: support joint damping and friction parameters #712

Open
Tracked by #545
scpeters opened this issue Jan 13, 2025 · 2 comments
Open
Tracked by #545

bullet-featherstone: support joint damping and friction parameters #712

scpeters opened this issue Jan 13, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@scpeters
Copy link
Member

Part of #545.

Desired behavior

The //joint/axis*/dynamics/damping and //joint/axis*/dynamics/friction parameters are read from SDFormat by the bullet-featherstone SDFFeatures::ConstructSdfModelImpl method and written to the m_jointDamping and m_jointFriction member variables of btMultibodyLink, but a todo code comment in the btMultibodyLink.h indicates that those variables are not yet used.

We either need to implement support for these parameters in upstream bullet or implement an explicit joint damping workaround (see gazebo::physics::ODEJoint::ApplyExplicitStiffnessDamping from gazebo-classic for reference).

Alternatives considered

Implementation suggestion

Additional context

@scpeters scpeters added the enhancement New feature or request label Jan 13, 2025
@azeey azeey moved this from Inbox to To do in Core development Jan 13, 2025
@azeey azeey added the help wanted Extra attention is needed label Jan 13, 2025
@Sukhvansh2004
Copy link

Hi, can I work on this task?

@iche033
Copy link
Contributor

iche033 commented Jan 21, 2025

I think we'll need to first confirm that built-in support for joint damping / friction is available in bullet-featherstone implementation upstream or not. If not, I found this old post for doing it using btMultibodyJointMotor. Note that in our ode, we currently only create a joint motor when users set joint velocities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

4 participants