Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: FrameData is incorrect for collisions, joints, and models #648

Open
iche033 opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@iche033
Copy link
Contributor

iche033 commented Jun 4, 2024

Environment

  • OS Version: Ubuntu 20.04
  • Source or binary build? source build, gz-physics7 branch

Description

In bullet-featherstone plugin, The frame data computation is done in the KinematicsFeatures::FrameDataRelativeToWorld. The Pose FrameData for collisions was updated to take into account collision pose offset in #647. However, the velocities FrameData still do not incorporate the collision pose offset.

@iche033
Copy link
Contributor Author

iche033 commented Jun 4, 2024

The JointFrameSemantics may also be incorrect in bullet-featherstone plugin. After fixing / enabling these frame data checks, the test fails:

97: Expected equality of these values:
97:   F_WCexpected.pose.translation()
97:     Which is: { 0, 1.23942, -0.569664 }
97:   childLinkFrameData.pose.translation()
97:     Which is: { 0, 0.619709, 0.215168 }

The F_WCexpected.pose.translation() is calculated using joint frame semantics and the resulting values are incorrect, while the values of childLinkFrameData.pose.translation are correct.

@iche033 iche033 changed the title bullet-featherstone: Velocities FrameData for collisions do not take into account collision pose offset. bullet-featherstone: FrameData is incorrect for collisions, joints, and models Jun 5, 2024
@iche033
Copy link
Contributor Author

iche033 commented Jun 5, 2024

ModelFrame data is also incorrect, see #647 (comment).

This commit adds a failing test: 27deae9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant