Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error for AABBTree.cc #595

Closed
bchoineubility opened this issue Feb 5, 2024 · 2 comments
Closed

Compile error for AABBTree.cc #595

bchoineubility opened this issue Feb 5, 2024 · 2 comments

Comments

@bchoineubility
Copy link

bchoineubility commented Feb 5, 2024

Hi,

I have tried to build ignition-physics5-5.3.2 with Yocto system for ROS2. But, I have some errors as follows.

| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:44:17: error: 'gz' is not a namespace-name
|    44 | using namespace gz;
|       |                 ^~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:45:17: error: 'physics' is not a namespace-name
|    45 | using namespace physics;
|       |                 ^~~~~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:46:17: error: 'tpelib' is not a namespace-name
|    46 | using namespace tpelib;
|       |                 ^~~~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:49:1: error: 'AABBTree' does not name a type
|    49 | AABBTree::AABBTree()
|       | ^~~~~~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:56:1: error: 'AABBTree' does not name a type
|    56 | AABBTree::~AABBTree() = default;
|       | ^~~~~~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:59:6: error: 'AABBTree' has not been declared
|    59 | void AABBTree::AddNode(std::size_t _id, const math::AxisAlignedBox &_aabb)
|       |      ^~~~~~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:59:47: error: 'math' does not name a type
|    59 | void AABBTree::AddNode(std::size_t _id, const math::AxisAlignedBox &_aabb)
|       |                                               ^~~~
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:59:68: error: expected unqualified-id before '&' token
|    59 | void AABBTree::AddNode(std::size_t _id, const math::AxisAlignedBox &_aabb)
|       |                                                                    ^
| /home/bchoi/nvidia-yocto-bsp/bchoi-build/tmp/work/armv8a-oe4t-linux/ignition-physics5/5.3.2-r0/git/tpe/lib/src/AABBTree.cc:59:67: error: expected ')' before '&' token
|    59 | void AABBTree::AddNode(std::size_t _id, const math::AxisAlignedBox &_aabb)
|       |                       ~                                           ^~
|       |                                                                   )

I think AABBTree.cc could not find required namespaces in the build system, such as gz, physics. I could not find where they are defined yet.

Can you please help me fix these error?

BR,
Mark

@bchoineubility
Copy link
Author

Hi

I made some progress for this issue.
I think problem is namespace change from ignition to gz for tpe would not complete yet.

config.hh have gz namespace and it can be refered by ignition/physics/tpelib/Export.hh but, tpe have "gz/physics/tpelib/Export.h" and it even don't define include dir for it in the CMakeLists.txt.

I attached my patch for it and check it it correct.

0001-Fixed-compile-error-for-tpelib.patch

BR,
Mark

@azeey
Copy link
Contributor

azeey commented Feb 28, 2024

gz-physics 5.3.2 needs gz-math 6.13.0 or newer. Fix in #601

@azeey azeey moved this from Inbox to In progress in Core development Feb 28, 2024
@azeey azeey closed this as completed Feb 28, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Core development Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants