Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WheelSlipParametersCmd: add friction #464

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-sim#1845

Summary

The goal for gazebosim/gz-sim#1845 is to show how to use gz-transport parameters to emulate ROS parameters, with the parameters used by the gazebo_ros_wheel_slip plugin as a motivating example with the wheel_slip_parameters_cmd.proto message type. Since support for friction coefficients was added to that plugin in ros-simulation/gazebo_ros_pkgs#1393, this pull request adds corresponding lateral and longitudinal friction parameters to the proto message.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This adds lateral and longitudinal friction parameters
to the WheelSlipParametersCmd message to match the
parameters supported in the gazebo_ros_wheel_slip plugin.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from caguero as a code owner September 17, 2024 20:22
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 17, 2024
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we retarget it to main?

@scpeters scpeters changed the base branch from gz-msgs11 to main October 2, 2024 23:00
@scpeters
Copy link
Member Author

scpeters commented Oct 3, 2024

Looks good to me. Should we retarget it to main?

Retargeted

@scpeters scpeters merged commit 53712ed into main Oct 3, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/wheel_slip_parameters_cmd_friction branch October 3, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants