Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous housekeeping #398

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Miscellaneous housekeeping #398

merged 3 commits into from
Oct 13, 2023

Conversation

mjcarroll
Copy link
Contributor

  • Remove unused bazel file
  • Remove/rename unused headers
  • All the factory to read from multiple locations.

@mjcarroll
Remove unused bazel file
34b31ff 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Remove unused headers
9397692 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Allow factory to read from multiple locations
18bf943 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from caguero as a code owner October 12, 2023 14:26
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #398 (7c73127) into gz-msgs10 (0622409) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7c73127 differs from pull request most recent head 18bf943. Consider uploading reports for the commit 18bf943 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #398   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1172    +2     
==========================================
+ Hits            1138     1140    +2     
  Misses            32       32
Files Coverage Δ
core/include/gz/msgs/convert/Pose.hh 100.00% <ø> (ø)
core/src/DynamicFactory.cc 86.76% <100.00%> (+0.40%) ⬆️

@mjcarroll mjcarroll self-assigned this Oct 13, 2023
@mjcarroll mjcarroll merged commit edd9632 into gz-msgs10 Oct 13, 2023
5 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/cleanup_msgs10 branch October 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

@mjcarroll mjcarroll

Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @ahcorde