Simple test to do clang/asan builds on gz-math #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by robotlocomotion/drake's approach Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
requested review from
scpeters and
adityapande-1995
as code owners
Signed-off-by: Michael Carroll <[email protected]>
| build:clang --host_action_env=CC=clang-15 | ||
| build:clang --host_action_env=CXX=clang++-15 | ||
|
|
||
| ### ASan build. Clang only. ### |
There was a problem hiding this comment.
nit: consider adding that both --config asan --config clang need to be passed to bazel
| @@ -0,0 +1,5 @@ | |||
| sh_binary( | |||
There was a problem hiding this comment.
nit: consider adding a docstring on how this can be run locally
bazel run --config asan --config clang tools:asan?
shameekganguly
approved these changes
Nov 15, 2024
|
whoops. @ahcorde I think I actually found a better way of doing this. I'm going to revert. |
mjcarroll
added a commit
that referenced
this pull request
Nov 15, 2024
This reverts commit 757ead0.
mjcarroll
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by robotlocomotion/drake's approach