Deprecate math::clock alias #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommend using std::chrono::steady_clock directly instead of this alias. Fixes #436. Signed-off-by: Steve Peters <[email protected]>
This was referenced Jul 1, 2024
scpeters
commented
Jul 1, 2024
include/gz/math/Stopwatch.hh
Outdated
| using clock = std::chrono::steady_clock; | ||
| // This alias is now deprecated; please use std::chrono::steady_clock | ||
| // directly instead. | ||
| using clock GZ_DEPRECATED(8) = std::chrono::steady_clock; |
There was a problem hiding this comment.
windows CI doesn't like this
Stopwatch.hh(33,17): error C2062: type 'int' unexpected
There was a problem hiding this comment.
trying [[deprecated]] based on https://stackoverflow.com/a/50882131
Signed-off-by: Steve Peters <[email protected]>
scpeters
commented
Jul 1, 2024
| @@ -154,8 +155,8 @@ TEST(Stopwatch, StartStopReset) | |||
| watch.Start(true); | |||
| EXPECT_TRUE(watch.Running()); | |||
| EXPECT_LT(watch.StopTime(), watch.StartTime()); | |||
| EXPECT_NE(math::clock::duration::zero(), watch.ElapsedRunTime()); | |||
| EXPECT_EQ(math::clock::duration::zero(), watch.ElapsedStopTime()); | |||
| EXPECT_NE(steady_clock::duration::zero(), watch.ElapsedRunTime()); | |||
There was a problem hiding this comment.
windows failed on this line; I think it's flaky
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 147 147
Lines 10122 10123 +1
=======================================
+ Hits 9715 9716 +1
Misses 407 407 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Jul 2, 2024
mjcarroll
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #436.
Summary
Recommend using
std::chrono::steady_clockdirectly instead of this alias. This should already have been removed from downstreamgz-*packages.Test it
Compile Ionic workspace with this branch and watch for deprecation warnings.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.