Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warnings on MSVC #564

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Suppress warnings on MSVC #564

merged 1 commit into from
Oct 13, 2023

Conversation

mjcarroll
Copy link
Contributor

Fixes #257

@mjcarroll
Suppress warnings on MSVC
7415e6c 
Fixes #257

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #564 (49d3957) into ign-math6 (ea9ae34) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 49d3957 differs from pull request most recent head 7415e6c. Consider uploading reports for the commit 7415e6c to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #564   +/-   ##
==========================================
  Coverage      99.38%   99.38%           
==========================================
  Files             75       75           
  Lines           7029     7029           
==========================================
  Hits            6986     6986           
  Misses            43       43
Files Coverage Δ
include/gz/math/Helpers.hh 100.00% <100.00%> (ø)

@mjcarroll mjcarroll merged commit 9a5ad69 into ign-math6 Oct 13, 2023
9 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/supress_msvc branch October 13, 2023 22:07
@azeey azeey mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @azeey