Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cone as a primitive parametric shape. #620

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented May 13, 2024

🦟 Bug fix

Summary

This helps add the missing cone geometry for primitive/basic parametric shapes:

conetopple
cone

And is also valuable for visualizations of emitters/source that typically have conic-based spread as seen in this acoustic attack on an IMU by showing the affected area:

drone_attack

Associated PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine
Copy link
Contributor

I see you also opened a PR targeting Ionic #621

Is there a reason these are in two separate PRs? This may lead issues to forward porting. Could we close the one targeting Ionic, merge this one into harmonic, then forward port the feature to ionic?

@bperseghetti
Copy link
Member Author

I see you also opened a PR targeting Ionic #621

Is there a reason these are in two separate PRs? This may lead issues to forward porting. Could we close the one targeting Ionic, merge this one into harmonic, then forward port the feature to ionic?

This is just placeholder for the backport soon as rest of this gets in. Only one that needs merging/review right now is: #621

@iche033 iche033 merged commit 92f9d78 into gazebosim:gz-gui8 Jun 20, 2024
8 checks passed
@bperseghetti bperseghetti deleted the pr-cone branch June 21, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants