Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 4.0.0 #191

Merged
merged 1 commit into from
Mar 31, 2021
Merged

🎈 4.0.0 #191

merged 1 commit into from
Mar 31, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Mar 30, 2021

🎈 Release

Preparation for 4.0.0 release.

Comparison to 3.11.1: ignition-common3_3.11.1...ign-common4

Targets new branch: ign-common4.

Requires:

gazebo-tooling/release-tools#421

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from j-rivero March 30, 2021 22:18
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #191 (9e63800) into ign-common4 (2f2b229) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e63800 differs from pull request most recent head cefc702. Consider uploading reports for the commit cefc702 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #191   +/-   ##
============================================
  Coverage        75.48%   75.48%           
============================================
  Files               73       73           
  Lines            10349    10349           
============================================
  Hits              7812     7812           
  Misses            2537     2537           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2b229...cefc702. Read the comment docs.

@chapulina
Copy link
Contributor Author

Dependencies have been released, this is ready

@chapulina chapulina marked this pull request as ready for review March 31, 2021 02:18
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, feel free to drop the suggestion

@@ -14,7 +14,7 @@ set(IGN_CMAKE_VER ${ignition-cmake2_VERSION_MAJOR})
#============================================================================
# Configure the project
#============================================================================
ign_configure_project(VERSION_SUFFIX pre2)
ign_configure_project(VERSION_SUFFIX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a VERSION_SUFFIX empty looks weird. I assume it would work and it is convenient for the next time.

Suggested change
ign_configure_project(VERSION_SUFFIX)
ign_configure_project()

I would remove it but just a personal taste.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I've been leaving it everywhere 😕 I'm inclined to leaving it like this now just so all libraries follow the same pattern. But I agree it looks weird.

@chapulina chapulina merged commit d496d79 into ign-common4 Mar 31, 2021
@chapulina chapulina deleted the chapulina/4.0.0 branch March 31, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants