-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎈 4.0.0 #191
🎈 4.0.0 #191
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common4 #191 +/- ##
============================================
Coverage 75.48% 75.48%
============================================
Files 73 73
Lines 10349 10349
============================================
Hits 7812 7812
Misses 2537 2537 Continue to review full report at Codecov.
|
Dependencies have been released, this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, feel free to drop the suggestion
@@ -14,7 +14,7 @@ set(IGN_CMAKE_VER ${ignition-cmake2_VERSION_MAJOR}) | |||
#============================================================================ | |||
# Configure the project | |||
#============================================================================ | |||
ign_configure_project(VERSION_SUFFIX pre2) | |||
ign_configure_project(VERSION_SUFFIX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a VERSION_SUFFIX empty looks weird. I assume it would work and it is convenient for the next time.
ign_configure_project(VERSION_SUFFIX) | |
ign_configure_project() |
I would remove it but just a personal taste.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I've been leaving it everywhere 😕 I'm inclined to leaving it like this now just so all libraries follow the same pattern. But I agree it looks weird.
🎈 Release
Preparation for 4.0.0 release.
Comparison to 3.11.1: ignition-common3_3.11.1...ign-common4
Targets new branch:
ign-common4
.Requires:
🎈 6.8.0 gz-math#202🎈 1.0.0 gz-utils#18gazebo-tooling/release-tools#421
Checklist
Updated migration guide (as needed)Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):Note to maintainers: Remember to use Squash-Merge