-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reflectance output image for DepthCamera #2966
Open
WilliamLewww
wants to merge
18
commits into
gazebosim:gazebo11
Choose a base branch
from
WilliamLewww:wlew/depth_camera_reflectance
base: gazebo11
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+254
−69
Open
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
03b65b5
Added reflectance output image
WilliamLewww 6733e9b
Fixed style from codecheck
WilliamLewww 2c41445
Removed virtual modifier to prevent ABI break
WilliamLewww 8e4decc
Update style from suggestion
WilliamLewww a28d71c
Added test for depth camera reflectance image topic
WilliamLewww a29747c
Encapsulated data into test class
WilliamLewww dcd579f
Merge pull request #1 from WilliamLewww/wlew/depth_camera_reflectance_2
WilliamLewww 499b47e
Encapsulated variables and functions for rest of tests
WilliamLewww f3ad4c9
Fixed formatting from code check
WilliamLewww e51d311
Merge pull request #2 from WilliamLewww/wlew/depth_camera_reflectance_2
WilliamLewww 5d3646e
Fixed formatting with pointers and references
WilliamLewww e30dc2b
Merge pull request #3 from WilliamLewww/wlew/depth_camera_reflectance_2
WilliamLewww ca05d96
Removed topic that is never published
WilliamLewww c776173
Inverted reflectance output
WilliamLewww 0106de6
Merge branch 'gazebo11' into wlew/depth_camera_reflectance
scpeters c9d9b3e
Removed data inversion in sensor
WilliamLewww b3f1fe4
Prevent image reversing on reflectance image
WilliamLewww 87ec97f
Merge branch 'gazebo11' into wlew/depth_camera_reflectance
scpeters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you clarify what the values in this array mean physically? does 0 mean nonreflective and 1 mean reflective?
I'm asking because you inverted the data in c776173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh we should not invert the data on the sensors side. We should only update the visualization code. The gui visualization inverts the data when it detects that the underlying image has a FLOAT type:
https://github.com/osrf/gazebo/blob/gazebo11/gazebo/gui/viewers/ImageFrame.cc#L157-L167
The logic there was added for visualization of depth data, i.e. black pixels means far away while white means close to camera. However, now that the reflectance image output is also in FLOAT, we don't want the inversion to be applied to the reflectance image. I think there needs to be some way on the gui side to tell reflectance images from depth images so that the correct visualization is applied.