Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortress #174

Merged
merged 7 commits into from
Apr 21, 2021
Merged

Fortress #174

merged 7 commits into from
Apr 21, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Apr 1, 2021

Add Ignition Fortress.

Keeping as draft until the nightlies are available.

gazebo-tooling/release-tools#421

gazebo-tooling/release-tools#428

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Apr 10, 2021
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added 🏯 fortress Ignition Fortress and removed 🏢 edifice Ignition Edifice labels Apr 14, 2021
@chapulina chapulina marked this pull request as ready for review April 14, 2021 00:16
@chapulina chapulina marked this pull request as draft April 14, 2021 00:16
@chapulina
Copy link
Contributor Author

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Apr 20, 2021
@chapulina
Copy link
Contributor Author

Fortress nightlies are out, this is open for review!

@chapulina chapulina marked this pull request as ready for review April 20, 2021 23:51
@adlarkin adlarkin self-requested a review April 21, 2021 15:08
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

tools/branch_comparisons.md Show resolved Hide resolved
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, but LGTM once #174 (comment) is addressed.

fortress/install_osx_src.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Ashton Larkin <[email protected]>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@chapulina chapulina merged commit 90306fa into master Apr 21, 2021
@chapulina chapulina deleted the chapulina/fortress branch April 21, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants