Change nightly call to support new API tokens #1206
Draft
+116
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
changed the title
Signed-off-by: Jose Luis Rivero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #1201.
1. Adapt the release.py to not use the jenkins.ini file
The PR prepares the new auth method to work with nightly generation. To call release.py with osrfbuild bot account this PR implements the
--authparameter that supportsuser:tokento be passes as argument to authenticate in our Jenkins. The token can potentially be a Jenkins API token or a GitHub Token. d7dcb2dThis has the side effect on the test code that we no longer need the
_RELEASEPY_TEST_CREDENTIALS, removed in af2ecae.2. Change release-tools DSL to modify the nightly_scheduler code
Remove existing shared token injection and use credentials plugin in Jenkins to pass GITHUB_TOKEN. Use that with the
--authmechanism implemented in 1. 85ea8883. Test DSL to check that token is able to login in Jenkins and use the osrfbuild fork
Hijack part of #353 and add a test to check that that the token is able to login into Jenkins. 07a29cb. The new token should have the fine-grained permissions on osrfbuild/homebrew-simulation fork for "Contents".
The existing
GITHUB_TOKENfor the osrfbuild user in Jenkins does not seem to work to authenticate into Jenkins. This links with the old PR #353 that probably needs to be resurrected first.