Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for ups.power.nominal. #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faugusztin
Copy link

Some UPS report their capacity using the ups.power.nominal property, which gives value in VA.
We can calculate the power consumption in W from VA value provided in ups.power.nominal,
adjusted by load percentage and converted via CosPhi.

Related to #68.

Some UPS report their capacity using the ups.power.nominal property, which gives value in VA.
We can calculate the power consumption in W from VA value provided in ups.power.nominal,
adjusted by load percentage and converted via CosPhi.

Related to gawindx#68.
@gawindx
Copy link
Owner

gawindx commented Mar 2, 2021

I have taken your request into account, but I am actively working on v2.1 and I admit that I do not have too much time to manage the request for the moment.
At first glance, I don't see anything blocking but I think that your modification will be integrated and credited directly on the next version.

@gawindx
Copy link
Owner

gawindx commented Mar 11, 2021

I close the pull requests and, as promised, your modification is directly integrated in 2.1.
don't hesitate to give me a feedback if it doesn't work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants