Version check fix

gautamdsheth · Nov 22, 2024 · 16ecb6e · 16ecb6e
1 parent eabe53e
commit 16ecb6e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Commands/Base/GetDiagnostics.cs b/src/Commands/Base/GetDiagnostics.cs
@@ -64,7 +64,7 @@ void FillCurrentSite(Diagnostics result)
         void FillNewerVersionAvailable(Diagnostics result)
         {
             var versionAvailable = VersionChecker.GetAvailableVersion();
-            if (versionAvailable != null && VersionChecker.IsNewer(versionAvailable.Version))
+            if (versionAvailable != null && VersionChecker.IsNewer(versionAvailable.SemanticVersion))
             {
                 result.NewerVersionAvailable = versionAvailable.ToString();
             }

diff --git a/src/Commands/Utilities/VersionChecker.cs b/src/Commands/Utilities/VersionChecker.cs
@@ -5,6 +5,7 @@
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Reflection;
+using System.Text.Json.Serialization;
 using System.Xml;
 using System.Xml.Linq;
 
@@ -73,7 +74,7 @@ public static void CheckVersion(PSCmdlet cmdlet)
                 if (onlineVersion != null)
                 {
 
-                    if (IsNewer(onlineVersion.Version))
+                    if (IsNewer(onlineVersion.SemanticVersion))
                     {
                         if (cmdlet != null)
                         {
@@ -229,7 +230,15 @@ public static PnPVersionResult GetAvailableVersion()
 
     public class PnPVersionResult
     {
-        public SemanticVersion Version { get; set; }
+        public string Version { get; set; }
+        public SemanticVersion SemanticVersion
+        {
+            get
+            {
+                SemanticVersion.TryParse(Version, out SemanticVersion result);
+                return result;
+            }
+        }
         public string Message { get; set; }
     }
 }