feat: Support custom toml file path
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
Feb 3, 2025
src/common/version.ts
Outdated
|
|
||
| const MIN_VERSION_WITH_CONFIG = { | ||
| major: 0, | ||
| minor: 24, |
There was a problem hiding this comment.
We'll tweak this before merging.
max-muoto
commented
Feb 3, 2025
| patch: 0, | ||
| }; | ||
|
|
||
|
|
There was a problem hiding this comment.
Doesn't seem we enforce any type of formatting? Mind if I do a quick follow-up adding Biome?
There was a problem hiding this comment.
Yeah that works for me 👍 I've typically used prettier but Biome looks good.
max-muoto
force-pushed
the
support-custom-toml-path
branch
from
6125e90 to
7e36d73
Compare
emdoyle
approved these changes
Feb 3, 2025
max-muoto
force-pushed
the
support-custom-toml-path
branch
from
2a7daa5 to
6aff600
Compare
Bumped the version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to support a custom
tomlconfiguration path.