Merge pull request #1 from sparshg/update

Update extension to work with latest tach version

README.md

@@ -2,12 +2,8 @@
 
 
 ### Setup
-1. Install the extension
-2. Navigate to the settings for the extension in VS Code. `Extensions > Tach`
-3. Add two arguments to `Tach:Args`:
-   1. `--root`
-   2. `path/to/tach.yml/dir`
-4. Run `Tach: Restart Server` from the command palette (`CMD+SHFT+P`)
-5. That's it! You should see invalid imports highlighted as errors on save.
+1. Install the extension and you should see invalid imports highlighted as errors on save.
+2. Navigate to the settings for the extension in `Extensions > Tach` to set arguments if needed. 
+3. Run `Tach: Restart Server` from the command palette (`CMD+SHFT+P`) to restart the server.
 
 If you run into any issues, let us know by either reaching out on [Discord](https://discord.gg/a58vW8dnmw) or submitting a [Github Issue](https://github.com/gauge-sh/tach/issues)!

bundled/tool/lsp_server.py

@@ -11,6 +11,7 @@
 import sys
 import traceback
 from typing import Any
+from tach.check import CheckResult
 
 
 # **********************************************************
@@ -99,30 +100,25 @@ def did_close(params: lsp.DidCloseTextDocumentParams) -> None:
 
 
 def _linting_helper(document: workspace.Document) -> list[lsp.Diagnostic]:
-    boundary_errors = _run_tool_on_document(document)
-    return (
-        _parse_boundary_errors(boundary_errors, document.uri) if boundary_errors else []
-    )
+    checked_result = _run_tool_on_document(document)
+    return _parse_boundary_errors(checked_result, document.uri)
 
 
-def _parse_boundary_errors(boundary_errors, uri):
+def _parse_boundary_errors(checked_result: CheckResult, uri):
     diagnostics = []
-    for boundary_error in boundary_errors:
-        if (
-            boundary_error.file_path in uri
-            and boundary_error.error_info.exception_message
-        ):
+    for err in checked_result.errors:
+        if str(err.file_path) in uri and err.error_info.exception_message:
             start = lsp.Position(
-                line=boundary_error.line_number - 1,
+                line=err.line_number - 1,
                 character=0,
             )
-            end = lsp.Position(line=boundary_error.line_number - 1, character=99999)
+            end = lsp.Position(line=err.line_number - 1, character=99999)
             diagnostic = lsp.Diagnostic(
                 range=lsp.Range(
                     start=start,
                     end=end,
                 ),
-                message=boundary_error.error_info.exception_message,
+                message=err.error_info.exception_message,
                 severity=lsp.DiagnosticSeverity.Error,
                 source=TOOL_MODULE,
             )

bundled/tool/tach_util.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from tach.check import BoundaryError, check
+from tach.check import CheckResult, check
 from tach.cli import parse_arguments
 from tach.colors import BCOLORS
 from tach.constants import CONFIG_FILE_NAME
@@ -11,9 +11,7 @@
 
 def run_tach_check(argv: list[str], path: str):
     args, _ = parse_arguments(argv[1:])
-    root = args.root
-    if args.root == ".":
-        root = find_project_config_root(path)
+    root = find_project_config_root()
     if not root:
         raise TachSetupError("Project config root not found")
     exclude_paths = args.exclude.split(",") if getattr(args, "exclude", None) else None
@@ -28,12 +26,10 @@ def run_tach_check(argv: list[str], path: str):
     else:
         exclude_paths = project_config.exclude
 
-    boundary_errors: list[BoundaryError] = check(
-        root,
-        project_config,
-        exclude_paths=exclude_paths,
+    checked_result: CheckResult = check(
+        project_root=root, project_config=project_config, exclude_paths=exclude_paths
     )
-    for boundary_error in boundary_errors:
+    for boundary_error in checked_result.errors:
         # Hack for now - update error message displayed to user
         error_info = boundary_error.error_info
         if (
@@ -44,4 +40,4 @@ def run_tach_check(argv: list[str], path: str):
                 f"Cannot import '{boundary_error.import_mod_path}'. "
                 f"Module '{error_info.source_module}' cannot depend on '{error_info.invalid_module}'."
             )
-    return boundary_errors
+    return checked_result

package.json

@@ -2,7 +2,7 @@
     "name": "tach",
     "displayName": "Tach",
     "description": "Linting support for python files using `tach`.",
-    "version": "0.5.21",
+    "version": "0.10.0",
     "preview": true,
     "serverInfo": {
         "name": "Tach",