Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updates to options page functionality from #114 #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonsherrard
Copy link

@jonsherrard jonsherrard commented Aug 6, 2021

Hi there,

I've implemented the code from here #114, such that changes to ACF options pages will be added to the activity monitor.

Apologies, for the life of me I can not get the formatting to match up with the project style. I've got a heinously strict Symfony cs-fixer setup that won't stop running.

Cheers!

@blakej115
Copy link

Bump, I would really appreciate if this could get merged. It's super jank having to manually overwrite the plugin for this. Thank you!

@jonsherrard
Copy link
Author

jonsherrard commented Oct 19, 2021

@blakej115 you can composer require devular/wp-gatsby if you're installing with composer and packagist in the meantime

Copy link
Contributor

@henrikwirth henrikwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and looking for a solution, since I also am looking for one. I think it will need a different approach though.

'acf/delete_field_group',
function() {
add_action(
'acf/save_post',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger on every save_post. This means on every type of post update this will be triggered in addition to ActionMonitors already in place.

function() {
add_action(
'acf/save_post',
function () {
$this->trigger_schema_diff(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding trigger_schema_diff is for the case of a schema change. For example changing Advanced Custom Fields field groups. In the case of an Option Page update we are looking for a content change though, content that is written in the wp_options table specifically.

@henrikwirth henrikwirth mentioned this pull request Nov 30, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants