[Helm]feat: add support for reverse proxy through extraContent #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetillot
reviewed
Dec 5, 2024
helm-chart/values.yaml
Outdated
| @@ -49,7 +49,9 @@ controlPlane: | |||
| cpu: "1" | |||
| # Security context for the pod or container | |||
| securityContext: {} | |||
| #extra_content: {} # Extra content (currently commented out) | |||
| #extraContent: # Extra content, needed if you want to configure a reverse proxy for control plane. | |||
There was a problem hiding this comment.
question: why in extraContent ?
There was a problem hiding this comment.
To dynamically inject new configurations without frequently updating the control plane configuration in Helm, this approach minimizes the need for frequent releases and version updates. WDYT?
There was a problem hiding this comment.
But don't we lost helm generated documentation?
I see no difference with adding the field for real
slandelle
reviewed
Dec 5, 2024
slandelle
requested changes
Dec 5, 2024
helm-chart/values.yaml
Outdated
| @@ -49,7 +49,9 @@ controlPlane: | |||
| cpu: "1" | |||
| # Security context for the pod or container | |||
| securityContext: {} | |||
| #extra_content: {} # Extra content (currently commented out) | |||
| #extraContent: # Extra content, needed if you want to configure a reverse proxy for control plane. | |||
tpetillot
requested changes
Dec 5, 2024
helm-chart/templates/_config.tpl
Outdated
Comment on lines
52
to
56
| {{- with .extraContent }} | ||
| {{- range $key, $value := . }} | ||
| {{ $key }} = {{ toJson $value }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
I kept it here since you added it to AWS Terraform configs for dev purposes. Will you need it in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.