Scenario Specific Viewports

[SengitU]

This PR will provide scenario specific viewports. Previously, tests were executing accordingly to viewports provided by configuration. With this PR, global viewports will be able to overrided by the scenario specific ones.

For more information see #472

[garris]

Yes. Looks good!

A few comments.

• please add a test with an empty scenario.viewports array []. I think this case should fall back to the root viewports array.

• please use unique label and dimension values in your scenarioSpecificViewports test.

• Please add an additional test that specifies four viewports with unique values.

• Please add an additional test that uses the four viewports from above but also uses the expandSelector: true prop.

• please think of any other potential property/feature conflict and add a test for that as well 😉

[garris]

Thanks for this PR! I don't have enough time to publish this today but this will definitely go out in the next release.

[garris]

Pushed to NPM. V3.5.8

[SengitU]

@garris Hello, thanks for merging and releasing this so fast!

[SengitU]

Hello again @garris ,

I tried to use the changes today, but I couldn't find the changes in the code. I can't see changes also in unpkg; https://unpkg.com/[email protected]/core/util/createBitmaps.js

Am I doing something wrong?

[garris]

🤔

Ok, I’ll try to check this today.

[garris]

Ok, apologies. My bad. Please validate using v3.5.9. Thanks!

[SengitU]

It's working now, thanks for your help all along! 🎊