Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #842 by removing CSS transition #843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KenCoder
Copy link
Contributor

No description provided.

@gabegorelick
Copy link
Contributor

@garris Any reason not to merge this?

@garris
Copy link
Owner

garris commented Sep 28, 2018

Yes. This is a real-life use case. One can't just change product design because it's inconvenient to test. There are plenty of ways to approach this.

@gabegorelick
Copy link
Contributor

I'm not sure I follow? Is the CSS transition on the lemur that integral that's it's worth not having smoke tests?

I agree that it would be nice to get smoke tests working with transitions, but if the alternative is no smoke tests, to me the choice is obvious.

Perhaps we can merge this, get smoke tests working, then work on bringing the transition back?

@garris
Copy link
Owner

garris commented Sep 28, 2018

At very least one could use hideSelector to have backstop ignore the image. What would be better is to add a class after the transition is complete and just use that as the ready trigger.

@gabegorelick
Copy link
Contributor

@KenCoder Is that something you'd be able to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants