Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new selector: activeSelector for chromy #727

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add new selector: activeSelector for chromy #727

wants to merge 5 commits into from

Conversation

silentHoo
Copy link

I needed an activeSelector so I want to share it with the community.

garris
garris reviewed Apr 19, 2018
View reviewed changes
Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap — I didn’t realize this was only on chromy. Is it possible to do this in Puppeteer as well? Sorry.

@silentHoo
Copy link
Author

I've added the implementation for casper and puppet but it's not yet tested because lack of time atm. Could anyone test the code? Best regards.

garris
garris approved these changes Apr 26, 2018
View reviewed changes
Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@garris
Copy link
Owner

garris commented Apr 26, 2018

Let’s also add this to the backstop_feature test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garris garris garris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silentHoo @garris