Do not set PHANTOMJS_EXECUTABLE under all circumstances #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two cases in which PHANTOMJS_EXECUTABLE should not be set, I
think:
1. If the return value of findExecutable('phantomjs-prebuilt', 'phantomjs')
is null. This might be the case because the path export of the phantomjs module
can be null (https://github.com/Medium/phantomjs/blob/master/lib/phantomjs.js#L25).
2. If PHANTOMJS_EXECUTABLE is already set from outside.
Should solve most of garris#346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two cases in which
PHANTOMJS_EXECUTABLEshould not be set, Ithink:
findExecutable('phantomjs-prebuilt', 'phantomjs')is null. This might be the case because the path export of the phantomjs module
can be null.
PHANTOMJS_EXECUTABLEis already set from outside.Should solve most of #346.