Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reload page on error #1179

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e998459
Reload single URL if responded with invalid status
Apr 24, 2020
4bc7eb2
Update README.md
sapcik Apr 24, 2020
08a6440
- Reload page after error X times
Apr 28, 2020
0866918
Merge branch 'feature/reload-page-on-error' of github.com:sapcik/Back…
Apr 28, 2020
954fd8c
Added label for errors
Apr 28, 2020
ffc292b
Fixed problem with timeout
Apr 30, 2020
8a04bf1
Bypass cache by adding random param to the URL
May 21, 2020
26a44fa
Bypass cache by adding random param to the URL (for reference & test)
May 21, 2020
693ba11
Added additional delay
May 21, 2020
f89146b
Wait for networkidle2
May 21, 2020
4b71d92
Reload page
May 27, 2020
3af4c65
Added logs
May 27, 2020
37362b1
Added reload instead of goto
May 27, 2020
01fa0ea
Refresh page, hard reload from the JS
Jun 2, 2020
f3955d6
Updated puppeteer version
Jun 2, 2020
1acde5d
Do not reload
Jul 6, 2020
5ff769f
Reload single URL if responded with invalid status
Apr 24, 2020
20ddf6e
- Reload page after error X times
Apr 28, 2020
13b3e78
Update README.md
sapcik Apr 24, 2020
9dfb409
Added label for errors
Apr 28, 2020
54f6f23
Fixed problem with timeout
Apr 30, 2020
0bba28a
Bypass cache by adding random param to the URL
May 21, 2020
d59272a
Bypass cache by adding random param to the URL (for reference & test)
May 21, 2020
4df09f0
Added additional delay
May 21, 2020
4a974c1
Wait for networkidle2
May 21, 2020
cdf9f56
Reload page
May 27, 2020
fadc13d
Added logs
May 27, 2020
c1bd09f
Added reload instead of goto
May 27, 2020
5b53953
Refresh page, hard reload from the JS
Jun 2, 2020
f99b47b
Updated puppeteer version
Jun 2, 2020
1cd3dcc
Do not reload
Jul 6, 2020
81426a2
Merge branch 'feature/reload-page-on-error' of github.com:sapcik/Back…
Apr 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added reload instead of goto
Wojciech Sapiechowski committed May 27, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 37362b137ae9c933ec4aab833d943ccfe747410d
7 changes: 5 additions & 2 deletions core/util/runPuppet.js
Original file line number Diff line number Diff line change
@@ -131,9 +131,12 @@ async function processScenarioView (scenario, variantOrScenarioLabelSafe, scenar
bypass = '?bypassCache=' + Date.now()
}

console.log(chalk.green('Opening URL:', translateUrl(url) + bypass));
// Open the URL for a first time
await page.goto(translateUrl(url) + bypass, {waitUntil: 'networkidle0'});
var request = await page.goto(translateUrl(url) + bypass, {waitUntil: 'networkidle0'});

console.log(chalk.green('Opening URL:', translateUrl(url) + bypass));

var request = await page.reload(translateUrl(url) + bypass, {waitUntil: 'networkidle0'});

if (config.reloadOnError.enabled) {
// Check the status of the request