-
Notifications
You must be signed in to change notification settings - Fork 609
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
process.exit(1) upon any backstopjs errors
- Loading branch information
Kiran Chilakamarri
committed
Oct 5, 2017
1 parent
594613f
commit 548fad6
Showing
1 changed file
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
548fad6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this — but the hang-on-error issue was fixed in v3.0.29. Errors are now passed up and handled properly in the downstream report creation process. App-level thrown errors are now surfaced in the CLI report. On exit any remaining chromy process are cleaned up.