Skip to content

Commit

Permalink
process.exit(1) upon any backstopjs errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Kiran Chilakamarri committed Oct 5, 2017
1 parent 594613f commit 548fad6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/util/runChromy.js
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,9 @@ function processScenarioView (scenario, variantOrScenarioLabelSafe, scenarioLabe
));
})
.end()
.catch(e => reject(new BackstopException('Chromy error', scenario, viewport, e)))
.catch(e => process.exit(1)
// reject(new BackstopException('Chromy error', scenario, viewport, e))
)
});
}

Expand Down

1 comment on commit 548fad6

@garris
Copy link
Owner

@garris garris commented on 548fad6 Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this — but the hang-on-error issue was fixed in v3.0.29. Errors are now passed up and handled properly in the downstream report creation process. App-level thrown errors are now surfaced in the CLI report. On exit any remaining chromy process are cleaned up.

Please sign in to comment.