Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the HTML markup and add Debian Wheezy 7.2 amd64 (Minimal) with Ruby 2.0.0p247 and VirtualBox 4.2.18 #207

Closed
wants to merge 2 commits into from

Conversation

willian
Copy link
Contributor

@willian willian commented Oct 16, 2013

No description provided.

@fgrehm
Copy link
Collaborator

fgrehm commented Oct 16, 2013

Sorry but the HTML changes will probably have to wait a little bit, we are already having trouble merging PRs because I merged #154 before others and now we have to manually merge older PRs to deal with conflicts as most (if not all) of them can't be merged automatically from GitHub UI.

If we bring this one in we'd end up having even more trouble when dealing with conflicts so I'd kindly ask you to you split this PR in two so that we can merge the Debian Wheezy box right away :)

/cc @garethr

@willian
Copy link
Contributor Author

willian commented Oct 16, 2013

No problem, I'll do that 😉

What you think if we put all boxes informations in a Javascript Array of objects and create the HTML using this Array as a Database?

This way will create a default for the data.

I can do this, just let me know if you agree.

@fgrehm
Copy link
Collaborator

fgrehm commented Oct 16, 2013

Not sure if this is what you mean but I remember talking to @garethr and he wants to stay away from rendering HTML on the client side, but I agree with you that the current approach of manually editing HTML is not optimal.

I think that after we are able to deal with the remaining PRs we should definitely look into making things easier for collaborators :)

@garethr
Copy link
Owner

garethr commented Oct 16, 2013

There was an older pull request that I didn't manage to get to which split the data into json files and then generated the HTML. Happy to do that, as long as the generated HTML either gets checked in to the repo or is generated on Travis as part of the deployment. Websites of data that require js make me sad.

@willian
Copy link
Contributor Author

willian commented Oct 16, 2013

@garethr, I agree with you, but I don't know a better way to organize it on client side.
What you think if we use something like Jekyll?

@garethr
Copy link
Owner

garethr commented Oct 19, 2013

Jekyll is pretty opinionated. Here's the pull request from ages ago (which I didn't see for ages, but in hindsight should have merged the moment it came in)

https://github.com/garethr/vagrantboxes-heroku/pull/29/files

The only thing I'd probably change is rather than one file with all the boxes in, have a separate file for each box. That would make the whole stream of pull requests simple to deal with.

If you're interested in working on this that would be great.

@willian
Copy link
Contributor Author

willian commented Oct 21, 2013

Sure, I'll work on it :)
Thank you so much to let me do this.

Best,

@fgrehm
Copy link
Collaborator

fgrehm commented Feb 2, 2014

@willian Just so you know, I've done a spike on using Jekyll, feel free to chime in on GH-271 ;-)

@JonTheNiceGuy
Copy link
Collaborator

I think this one needs to be closed, and a separate PR with just the box on it be raised (if you don't mind) - it's too much to try and find your box in this PR, and the other actions would break the list as it stands. Please address your website re-design suggestions on #271, or in a fresh PR using the current data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants