Allow configuration MaxGracefulTerminationSec flag on ClusterAutoscaler #4697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
rfranzke
requested changes
Sep 22, 2021
ialidzhikov
reviewed
Sep 23, 2021
rfranzke
previously approved these changes
Sep 27, 2021
There was a problem hiding this comment.
/lgtm
@prashanth26 do you plan to tackle @ialidzhikov's suggestion?
Apologies. I somehow forgot about the PR. Took in suggested changes. |
|
@prashanth26 Can you check why the failing |
Will check it out. |
Co-authored-by: Ismail Alidzhikov <[email protected]>
prashanth26
force-pushed
the
update-max-terminating-seconds
branch
from
af0bf15 to
e9bf065
Compare
One of the test variables wasn't renamed. I made the change and now the pipeline passes. PTAL. Also squashed all the changes. |
Kristian-ZH
pushed a commit
to Kristian-ZH/gardener
that referenced
this pull request
Sep 29, 2021
…ardener#4697) Co-authored-by: Ismail Alidzhikov <[email protected]> Co-authored-by: Ismail Alidzhikov <[email protected]>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
…ardener#4697) Co-authored-by: Ismail Alidzhikov <[email protected]> Co-authored-by: Ismail Alidzhikov <[email protected]>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…ardener#4697) Co-authored-by: Ismail Alidzhikov <[email protected]> Co-authored-by: Ismail Alidzhikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
During scale down of nodes in the cluster, the cluster autoscaler waits for a maximum of 10 minutes for any pod(s) to wait for graceful termination. However, this is a configurable flag at the cluster autoscaler to let the shoot owners decide the maximum time to wait while draining the node.
Which issue(s) this PR fixes:
Fixes #4695
Special notes for your reviewer:
The eventual plan would be to delegate the task of draining completely to the cluster autoscaler. In the meanwhile, this enhancement would give some breathing space for end-users to have a handle.
Release note: