Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local setup issues #194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ ci-e2e-kind: $(KIND) $(YQ)
export SKAFFOLD_BUILD_CONCURRENCY = 0
extension-up extension-dev: export SKAFFOLD_DEFAULT_REPO = localhost:5001
extension-up extension-dev: export SKAFFOLD_PUSH = true
extension-up extension-dev: export EXTENSION_VERSION = $(VERSION)
# use static label for skaffold to prevent rolling all gardener components on every `skaffold` invocation
extension-up extension-dev extension-down: export SKAFFOLD_LABEL = skaffold.dev/run-id=extension-local

Expand Down
44 changes: 40 additions & 4 deletions skaffold.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
apiVersion: skaffold/v4beta3
apiVersion: skaffold/v4beta7
kind: Config
metadata:
name: rsyslog-relp-echo-server
build:
tagPolicy:
customTemplate:
template: "{{.version}}-{{.sha}}"
components:
- name: version
envTemplate:
template: "{{.EXTENSION_VERSION}}"
- name: sha
inputDigest: {}
artifacts:
- image: local-skaffold/gardener-extension-shoot-rsyslog-relp-echo-server
docker:
Expand All @@ -22,11 +31,20 @@ deploy:
setValues:
service.clusterIP: 10.2.64.54
---
apiVersion: skaffold/v4beta3
apiVersion: skaffold/v4beta7
kind: Config
metadata:
name: extension
build:
tagPolicy:
customTemplate:
template: "{{.version}}-{{.sha}}"
components:
- name: version
envTemplate:
template: "{{.EXTENSION_VERSION}}"
- name: sha
inputDigest: {}
artifacts:
- image: local-skaffold/gardener-extension-shoot-rsyslog-relp
ko:
Expand Down Expand Up @@ -69,13 +87,31 @@ manifests:
paths:
- local-setup
deploy:
kubectl: {}
# --server-side apply is a workaround for https://github.com/gardener/gardener/issues/10267.
# kubectl apply attempts a strategic merge patch which fails for a ControllerDeployment.
# For more details, see https://github.com/gardener/gardener/issues/10267.
#
# TODO: Switch back to "kubectl: {}" when the above issue is resolved.
kubectl:
flags:
apply:
- --server-side
- --force-conflicts
---
apiVersion: skaffold/v4beta3
apiVersion: skaffold/v4beta7
kind: Config
metadata:
name: admission
build:
tagPolicy:
customTemplate:
template: "{{.version}}-{{.sha}}"
components:
- name: version
envTemplate:
template: "{{.EXTENSION_VERSION}}"
- name: sha
inputDigest: {}
artifacts:
- image: local-skaffold/gardener-extension-shoot-rsyslog-relp-admission
ko:
Expand Down