-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-26] Workload Identity support #999
Draft
dimityrmirchev
wants to merge
23
commits into
gardener:master
Choose a base branch
from
dimityrmirchev:wi-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
API change with impact on API users
needs/second-opinion
Needs second review by someone else
area/ipcei
IPCEI (Important Project of Common European Interest)
area/security
Security related
kind/enhancement
Enhancement, improvement, extension
platform/azure
Microsoft Azure platform/infrastructure
labels
Nov 1, 2024
@dimityrmirchev Label ipcei/workload-identity does not exist. |
gardener-robot
added
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
labels
Nov 1, 2024
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 1, 2024
@dimityrmirchev Label ipcei/workload-identity does not exist. |
49 tasks
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 4, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 4, 2024
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 4, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 5, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 5, 2024
dimityrmirchev
force-pushed
the
wi-support
branch
from
November 7, 2024 07:49
f46b9eb
to
7312678
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 7, 2024
@dimityrmirchev You need rebase this pull request with latest master branch. Please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ipcei
IPCEI (Important Project of Common European Interest)
area/security
Security related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/rebase
Needs git rebase
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
platform/azure
Microsoft Azure platform/infrastructure
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security ipcei
/kind enhancement
/label ipcei/workload-identity
/platform azure
What this PR does / why we need it:
This PR adds support for workload identity.
Which issue(s) this PR fixes:
Part of gardener/gardener#9586
Depends on:
Special notes for your reviewer:
cc @vpnachev
For the purpose of developing and testing this PR the local setup with extension + workload identity support can be utilised. https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally_with_extensions.md#setting-up-gardener-garden-on-kind-seed-on-gardener-cluster
Documentation in this PR is still to be added, but PR can be reviewed and tested. Please see the relevant azure documentation https://learn.microsoft.com/en-us/entra/workload-id/workload-identity-federation-create-trust?pivots=identity-wif-apps-methods-azp
Release note: