Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse ShootList Columns #1991

Merged
merged 43 commits into from
Sep 28, 2024
Merged

Collapse ShootList Columns #1991

merged 43 commits into from
Sep 28, 2024

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Jul 18, 2024

What this PR does / why we need it:
This PR introduces a new component CollapsibleItems that can be used to collapse items where the space is limited

Screenshot 2024-07-18 at 16 49 56

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

To enhance the overview and readability of the cluster list, particularly in environments constrained by space or containing an abundance of information, we have introduced a feature that allows items to be collapsed when they are displayed in the cluster list.

grolu and others added 29 commits February 8, 2024 17:08
@grolu
Collapse worker groups on cluster list
3f08857
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
2792754
@grolu
- fixed worker group margins
487b440 
- adjusted tooltip delay
- make button only visible on mouseover
- worker group chip not clickable
@grolu
Changed auto-hide activation
8d786af
@grolu
use v-hover to show / hide collapse button
22f57cf
@grolu
Reset expanded state when component gets reused
ec6bdcf
@grolu
Store expansion state in provided object
4c30d93
@grolu
Allow to toggle all worker groups using shift-click
bf65d39 
Some cleanup
@grolu
Refactored collapse logic into re-usable component
8e445be
@grolu
Use collapsable items component for access restrictions and ticket la…
02aa99b 
…bels
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
607d45e
@grolu
Collapse Readiness Tags
98e0e61
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
b2af61d
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
98a918b
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
c90b1b3
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
791ec17 
# Conflicts:
#	frontend/src/components/GShootListRow.vue
#	frontend/src/components/GStatusTags.vue
#	frontend/src/components/ShootAccessRestrictions/GAccessRestrictionChips.vue
#	frontend/src/components/ShootDetails/GShootDetailsCard.vue
#	frontend/src/components/ShootWorkers/GWorkerGroup.vue
#	frontend/src/components/ShootWorkers/GWorkerGroups.vue
@grolu
Merge branch 'master' into enh/consolidate_worker_groups
dc56056 
# Conflicts:
#	frontend/src/components/GShootListRow.vue
#	frontend/src/components/ShootAccessRestrictions/GAccessRestrictionChips.vue
@grolu
Cleanup
1535810
@grolu
React to shift press
e0956fd
@grolu
Merge
28de70a
@grolu
Further cleanup
3e0322e 
Hide collapse buttons via css
@grolu
Expand Items in Table Header
3da419b
@grolu
Removed expanded readiness condition state
15f83b0
@grolu
inject expanded items
dbc9340
@grolu
Use custom table header for all VDataTables to align headers
faa6e64
@grolu
Use collapsable items only where we actually want to collapse
c3f2f80
@grolu
Fixed wrong param
dea2dbc
@grolu
PR Feedback
32ccd55
@grolu
- Removed all unused functionality from GCollapsibleItems
8faf3b2 
- Removed GDataTableHeader
- Show number only for collapsed items
- Use VChipGroup for ticket labels
- Fixed sorting for numeric values
@grolu grolu requested a review from holgerkoser as a code owner July 18, 2024 14:51
@gardener-robot gardener-robot removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 17, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Sep 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 26, 2024
holgerkoser
holgerkoser approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm only a minor renaming comment

frontend/src/components/GCodeBlock.vue Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 27, 2024
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Sep 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Sep 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 28, 2024
@grolu grolu merged commit e7e5b5f into master Sep 28, 2024
8 checks passed
@grolu grolu deleted the enh/collapse_columns branch September 28, 2024 13:04
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 28, 2024
@petersutter petersutter mentioned this pull request Oct 9, 2024
Merged
@grolu grolu mentioned this pull request Oct 14, 2024
Closed
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
@grolu grolu mentioned this pull request Oct 14, 2024
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grolu @gardener-robot @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3