Skip to content

Commit

Permalink
PR Feedback: minor renaming
Browse files Browse the repository at this point in the history
  • Loading branch information
grolu committed Sep 28, 2024
1 parent a82a9fe commit acab187
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions frontend/src/components/GCodeBlock.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ SPDX-License-Identifier: Apache-2.0
>
<div
class="code-block-wrapper"
:style="{ 'max-height': height, 'min-width': width }"
:style="{ 'max-height': maxHeight, 'min-width': minWidth }"
>
<pre><code
ref="block"
Expand Down Expand Up @@ -62,11 +62,11 @@ export default {
},
props: {
lang: String,
height: {
maxHeight: {
type: [Number, String],
default: '450px',
},
width: {
minWidth: {
type: [Number, String],
default: '100%',
},
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Secrets/GSecretDialogAlicloud.vue
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ SPDX-License-Identifier: Apache-2.0
user: AliyunECSFullAccess, AliyunSLBFullAccess, AliyunVPCFullAccess, AliyunEIPFullAccess, AliyunNATGatewayFullAccess.
</p>
<g-code-block
height="100%"
max-height="100%"
lang="json"
:content="JSON.stringify(template, undefined, 2)"
/>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/Secrets/GSecretDialogAws.vue
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ SPDX-License-Identifier: Apache-2.0
</p>
<g-code-block
v-if="vendor==='aws'"
height="100%"
max-height="100%"
lang="json"
:content="JSON.stringify(templateAws, undefined, 2)"
/>
<div v-if="vendor==='aws-route53'">
<p>In this example, the placeholder for the hosted zone is Z2XXXXXXXXXXXX</p>
<g-code-block
height="100%"
max-height="100%"
lang="json"
:content="JSON.stringify(templateAwsRoute53, undefined, 2)"
/>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/ShootWorkers/GWorkerGroup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ SPDX-License-Identifier: Apache-2.0
<g-code-block
lang="yaml"
:content="workerGroupYaml"
height="100%"
max-height="100%"
/>
</v-window-item>
</v-window>
Expand Down

0 comments on commit acab187

Please sign in to comment.