-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build gardener/gardener dev images #181
Build gardener/gardener dev images #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we need make councourse-ci/publish
not required anymore in branch protection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
for @oliver-goetz
/lgtm |
@oliver-goetz: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz, timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@oliver-goetz: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind enhancement
What this PR does / why we need it:
Builds gardener/gardener dev images in prow.
presubmit jobs:
pull-gardener-verify-image-build
builds all targets of Dockerfile but is not pushing the results anywherepull-gardener-publish-test-images
is an optional job to build and publish images of an PR toeu.gcr.io/gardener-project/gardener
/test pull-gardener-publish-test-images
and takes about 5 minutespull-gardener-verify-image-build-release
,pull-gardener-publish-test-images-release
postsubmit jobs:
post-gardener-build-dev-images
builds and publishes images from master branch toeu.gcr.io/gardener-project/gardener
This approach is slightly different than the current setup, but still allows to build test images from a PR.
Another option could be changing
pull-gardener-publish-test-images
to a non-optional prow job, to publish images from each commit of any PR and removepull-gardener-verify-image-build
A minor change is updating kaniko to the latest patch level 1.8.1.
Which issue(s) this PR fixes:
Fixes #180 partly
Special notes for your reviewer:
concourse-ci/publish
should be deactivated in gardener/gardener when merging this PR