Support extended resources and ephemeral-storage for scale-from-zero specified in MachineClass NodeTemplate #334
Conversation
elankath
requested review from
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
| capacityAttributes := []v1.ResourceName{"cpu", "gpu", "memory"} | ||
|
|
||
| for _, attribute := range capacityAttributes { | ||
| for _, attribute := range coreResourceNames { |
There was a problem hiding this comment.
FYI - With this GPU is not considered a core resource.
There was a problem hiding this comment.
Yes, this was stupid oversight. I have gpuResourceNames but it makes more correct to have gpu inside coreReourceNames. To be honest in the real world Node we seem to be using only nvidia GPU's labels.
|
|
||
| func filterExtendedResources(allResources v1.ResourceList) (extendedResources v1.ResourceList) { | ||
| extendedResources = make(v1.ResourceList) | ||
| for _, n := range knownResourceNames { |
There was a problem hiding this comment.
Aren't we just filtering the knownResourceNames in this? What if I have some other extended resource which is not part of this list? I think in general that would be the case
There was a problem hiding this comment.
We are the removing the knownResources and keeping all other extended resources in this function. Will add a doc and unit-test to make this clear.
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
Corrected issues. Will test scale from zero for ephemeral storage and custom resources and add manual test-log tomorrow. I am unsure how to code an integration test for this though. |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
What this PR does / why we need it:
Right now in scale-from-zero cases, the autoscaler does not respect ephemeral-storage and extended resource specified in the
MachineClass.NodeTemplate. Only the standardcpu,gpuandmemoryare picked up. Neither is there any support for custom extended resource which are fully ignored presently.Which issue(s) this PR fixes:
Fixes #132
Special notes for your reviewer:
Release note: