Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPA pipelines #263

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix VPA pipelines #263

merged 1 commit into from
Dec 1, 2023

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Nov 30, 2023

What this PR does / why we need it:

  • Fix docker context for VPA image builds
  • Trigger VPA jobs only on changes in the vertical-pod-autoscaler directory

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2023
himanshu-kun
himanshu-kun approved these changes Nov 30, 2023
View reviewed changes
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
changes looks good but why are the vpa pipelines themselves failing with the master pipeline_definitions?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2023
@voelzmo
Copy link
Member Author

voelzmo commented Nov 30, 2023

but why are the vpa pipelines themselves failing with the master pipeline_definitions?

I think the current issue is with the docker context that the image builds get passed in – this seems currently broken in master and this PR tries to correct it. After merging this, they should be working.

@himanshu-kun himanshu-kun merged commit 42b21a1 into gardener:machine-controller-manager-provider Dec 1, 2023
10 of 16 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11 rishabh-11 is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voelzmo @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot