Sync with upstream `v1.28.0` #260

…ol-cinfig [civo] Support pool wise config

…loudProvider-Labelling CA - Correct Cloudprovider PR labelling to area/provider/<provider name>

At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]>

…s_linode Added the RBAC Permission to Linode.

[volcengine] fix(volcengine): don't build all providers when volcengine tag exists

Fixed Typo and Trailing-whitespace

…roposal KEP for allowing Addon Resizer 1.8 to scale based on container count

Skip healthiness check for non-existing similar node groups

chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml`

…formatting Add whitespace in comments and lists

this change adds some logging at verbosity levels 2 and 3 to help diagnose why the cluster-autoscaler does not consider 2 or more node groups to be similar.

- this taint leads to unexpected behavior - users expect CA to consider the taint when autoscaling Signed-off-by: vadasambar <[email protected]>

Signed-off-by: Vishal Anarse <[email protected]>

Bumps golang from 1.20.4 to 1.20.5. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Updated the owners of civo cloudprovider

cluster-autoscaler/cloudprovider/brightbox Allow scaled workers to be built from an image name pattern as well as an image id. This deals with long running clusters where the official image is updated with security changes over time.

Only set the registry value in the local Makefile if it is missing

AEP for support of in-place updates for VPA

Fix: correcting RBAC permission in oci oke examples

Modified the VPA content for the helm chart and Bump the CA image to 1.27.2

…s method

Update VPA scripts to use v1.

…vertical-pod-autoscaler/builder/golang-1.20.5 Bump golang from 1.20.4 to 1.20.5 in /vertical-pod-autoscaler/builder

…mes-for-init-containers When comparing PodSpec semantically, drop projected volumes for init containers

Bump version to 0.14.0 as a preparation for release.

Update vendor to Kubernetes 1.28.0-alpha.2

Clarify and simplify the "build and stage images" step.

Execute git commands to show the state of local clone of the repo.

…breaking-ca Fix zonal GCE outage breaking CA when only some of the zones are failed

Mention logs from kubernetes#5862 in release instructions

Addition of BinpackingLimiter interface

Signed-off-by: Dinesh B <[email protected]>

This makes it easier to distinguish between various users of the Go SDK.

…-buildx-builders Explicitly create and remove buildx builders for VPA components

…nformative add cluster-autoscaler name and version to the user agent

Looks like the first PR merged a bit too early, while there were open coments

voelzmo meets [requirements](https://github.com/kubernetes/community/blob/9504ce87ec14cff9455e794fdcbc5088c52f9dd9/community-membership.md#requirements-1): - K8s org members since 2023-02: kubernetes/org#4015 - Reviewer of 12 merged VPA PRs: https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+reviewed-by%3Avoelzmo+label%3Avertical-pod-autoscaler+is%3Amerged+ - Sent 10 merged VPA PRs: https://github.com/kubernetes/autoscaler/pulls?q=is%3Apr+label%3Avertical-pod-autoscaler+author%3Avoelzmo+is%3Amerged

Bump default VPA version to 0.14.0

Apply fixes to in place support VPA AEP

Add voelzmo to VPA reviewers

Minor tweaks after preparing VPA 0.14.0 release.

…caleFromZeroAnnotationsEnabled chore: remove unused func scaleFromZeroAnnotationsEnabled

…additions cluster-autoscaler: support Brightbox image pattern

Cluster Autoscaler: add more logging for balancing similar node groups

- happens when CA tries to check if the unmanaged fargate node is a part of ASG (it isn't) - and keeps on logging error Signed-off-by: vadasambar <[email protected]>

Signed-off-by: vadasambar <[email protected]>

[VPA] Add subresource status for vpa with e2e fix

…are more appropriate

Sort nodegroups in order of their ID

This reverts commit 1384c8b.

Revert "Add subresource status for vpa"

Previous "CropNodes" function of ScaleDownBudgetProcessor had an assumption that atomically-scaled node groups should be classified as "empty" or "drain" as a whole, however Cluster Autoscaler may classify some of the nodes from a single group as "empty" and other as "drain".

update agnhost image to pull from registry.k8s.io

Generated by runing: ``` go mod tidy go mod vendor ```

Update VPA vendor

…r-cleanup Replace `BuildTestContainer` with use of builder

sizes

Include short unregistered nodes in calculation of incorrect node group

Add atomic scale down option for node groups

Add BigDarkClown to Cluster Autoscaler approvers

…h-weird-temp-folder-name Quote temp folder name parameter to avoid errors

* Merged multiple tests into one single table driven test. * Fixed some typos.

…strator * Started handling scale up options for ZeroToMaxNodeScaling with the existing estimator * Skip setting similar node groups for the node groups that use ZeroToMaxNodeScaling * Renamed the autoscaling option from "AtomicScaleUp" to "AtomicScaling" * Merged multiple tests into one single table driven test. * Fixed some typos.

* Renamed the "AtomicScaling" autoscaling option to "ZeroOrMaxNodeScaling" to be more clear about the behavior.

Add support for scaling up with ZeroToMaxNodesScaling option

Change the tracking of APIVersion from a boolean indicating if the VPA is v1beta1 to the version string and make sure it gets exported in metrics. Add tests for the recommender metrics.

Add status field in subresource on crd yaml and add new ClusterRole system:vpa-actor to patch /status subresource. The `metadata.generation` only increase on vpa spec update. Fix e2e test for patch and create vpa

feat(metrics): add metrics to observe where time is consumed in scale up

Record all vpa api versions in recommender metrics

Add subresource status for vpa

Add EstimationContext to take into account runtime state of the autoscaling for estimations Implement static threshold Implement cluster capacity threshold for Estimation Limiter Implement similar node groups capacity threshold for Estimation Limiter Set default estimation thresholds

# Conflicts: # cluster-autoscaler/core/scaleup/orchestrator/orchestrator.go

Remove unneeded node groups regardless of scale down being in cooldown.

Due to the dependency of the MaxNodeProvisionTimeProvider on the context the provider was extracted to a dedicated package and injected to the ClusterStateRegistry after context creation.

For SNG threshold include capacity of the currently estimated node group (as it is not part of SNG itself) Replaced direct calls with use of getters in cluster capacity threshold Renamed getters removing the verb Get Replace EstimationContext struct with interface Add support for negative threshold value in estimation limiter

… estimation limiter

…imits Implement configurable thresholds for threshold based estimator

Add ClusterStateRegistry to the AutoscalingContext

Signed-off-by: Maximilian Rink <[email protected]>

* renames all PowerState* consts to vmPowerState* * moves vmPowerState* consts and helper functions to azure_util.go * changes default vmPowerState to vmPowerStateUnknown instead of vmPowerStateStopped when a power state is not set.

…unneeded-scaledown Azure: Bugfix: Check PowerState before setting OutOfResources on instance

- remove non-relevant comment related to rescheduler Signed-off-by: vadasambar <[email protected]>

Signed-off-by: vadasambar <[email protected]> fix: test cases failing for actuator and scaledown/eligibility - abstract default values into `config` Signed-off-by: vadasambar <[email protected]> refactor: rename global `IgnoreDaemonSetsUtilization` -> `GlobalIgnoreDaemonSetsUtilization` in code - there is no change in the flag name - rename `thresholdGetter` -> `configGetter` and tweak it to accomodate `GetIgnoreDaemonSetsUtilization` Signed-off-by: vadasambar <[email protected]> refactor: reset help text for `ignore-daemonsets-utilization` flag - because per nodegroup override is supported only for AWS ASG tags as of now Signed-off-by: vadasambar <[email protected]> docs: add info about overriding `--ignore-daemonsets-utilization` per ASG - in AWS cloud provider README Signed-off-by: vadasambar <[email protected]> refactor: use a limiting interface in actuator in place of `NodeGroupConfigProcessor` interface - to limit the functions that can be used - since we need it only for `GetIgnoreDaemonSetsUtilization` Signed-off-by: vadasambar <[email protected]> fix: tests failing for actuator - rename `staticNodeGroupConfigProcessor` -> `MockNodeGroupConfigGetter` - move `MockNodeGroupConfigGetter` to test/common so that it can be used in different tests Signed-off-by: vadasambar <[email protected]> fix: go lint errors for `MockNodeGroupConfigGetter` Signed-off-by: vadasambar <[email protected]> test: add tests for `IgnoreDaemonSetsUtilization` in cloud provider dir Signed-off-by: vadasambar <[email protected]> test: update node group config processor tests for `IgnoreDaemonSetsUtilization` Signed-off-by: vadasambar <[email protected]> test: update eligibility test cases for `IgnoreDaemonSetsUtilization` Signed-off-by: vadasambar <[email protected]> test: run actuation tests for 2 NGS - one with `IgnoreDaemonSetsUtilization`: `false` - one with `IgnoreDaemonSetsUtilization`: `true` Signed-off-by: vadasambar <[email protected]> test: add tests for `IgnoreDaemonSetsUtilization` in actuator - add helper to generate multiple ds pods dynamically - get rid of mock config processor because it is not required Signed-off-by: vadasambar <[email protected]> test: fix failing tests for actuator Signed-off-by: vadasambar <[email protected]> refactor: remove `GlobalIgnoreDaemonSetUtilization` autoscaling option - not required Signed-off-by: vadasambar <[email protected]> fix: warn message `DefaultScaleDownUnreadyTimeKey` -> `DefaultIgnoreDaemonSetsUtilizationKey` Signed-off-by: vadasambar <[email protected]> refactor: use `generateDsPods` instead of `generateDsPod` Signed-off-by: vadasambar <[email protected]> refactor: `globaIgnoreDaemonSetsUtilization` -> `ignoreDaemonSetsUtilization` Signed-off-by: vadasambar <[email protected]>

Signed-off-by: vadasambar <[email protected]>

- instead of passing all the processors (we only need `NodeGroupConfigProcessor`) Signed-off-by: vadasambar <[email protected]>

- add suffix to tests with `IgnoreDaemonSetsUtilization` set to `true` and `IgnoreDaemonSetsUtilization` set to `false` Signed-off-by: vadasambar <[email protected]>

Signed-off-by: vadasambar <[email protected]>

…xEmptyBulkDelete, and maxScaleDownParallelism to be the larger of the two flags in the case both are set

…f the NodeDeletion option to main.go

…odes-causing-logs-flood fix: CA on fargate causing log flood

Refactor autoscaler.go and static_autoscalar.go to move declaration o…

…aemonsets-utilization-per-nodegroup feat: set `IgnoreDaemonSetsUtilization` per nodegroup for AWS

…specting-bulk-delete fix: setting maxEmptyBulkDelete, and maxScaleDownParallelism to be the same value

…ithout extenders) Signed-off-by: vadasambar <[email protected]> refactor: rename `--scheduler-config` -> `--scheduler-config-file` to avoid confusion Signed-off-by: vadasambar <[email protected]> fix: `goto` causing infinite loop - abstract out running extenders in a separate function Signed-off-by: vadasambar <[email protected]> refactor: remove code around extenders - we decided not to use scheduler extenders for checking if a pod would fit on a node Signed-off-by: vadasambar <[email protected]> refactor: move scheduler config to a `utils/scheduler` package` - use default config as a fallback Signed-off-by: vadasambar <[email protected]> test: fix static_autoscaler test Signed-off-by: vadasambar <[email protected]> refactor: `GetSchedulerConfiguration` fn - remove falling back - add mechanism to detect if the scheduler config file flag was set - Signed-off-by: vadasambar <[email protected]> test: wip add tests for `GetSchedulerConfig` - tests are failing now Signed-off-by: vadasambar <[email protected]> test: add tests for `GetSchedulerConfig` - abstract error messages so that we can use them in the tests - set api version explicitly (this is what upstream does as well) Signed-off-by: vadasambar <[email protected]> refactor: do a round of cleanup to make PR ready for review - make import names consistent Signed-off-by: vadasambar <[email protected]> fix: use `pflag` to check if the `--scheduler-config-file` flag was set Signed-off-by: vadasambar <[email protected]> docs: add comments for exported error constants Signed-off-by: vadasambar <[email protected]> refactor: don't export error messages - exporting is not needed Signed-off-by: vadasambar <[email protected]> fix: add underscore in test file name Signed-off-by: vadasambar <[email protected]> test: fix test failing because of no comment on exported `SchedulerConfigFileFlag` Signed-off-by: vadasambar <[email protected]> refacotr: change name of flag variable `schedulerConfig` -> `schedulerConfigFile` - avoids confusion Signed-off-by: vadasambar <[email protected]> test: add extra test cases for predicate checker - where the predicate checker uses custom scheduler config Signed-off-by: vadasambar <[email protected]> refactor: remove `setFlags` variable - not needed anymore Signed-off-by: vadasambar <[email protected]> refactor: abstract custom scheduler configs into `conifg` package - make them constants Signed-off-by: vadasambar <[email protected]> test: fix linting error Signed-off-by: vadasambar <[email protected]> refactor: introduce a new custom test predicate checker - instead of adding a param to the current one - this is so that we don't have to pass `nil` to the existing test predicate checker in many places Signed-off-by: vadasambar <[email protected]> refactor: rename `NewCustomPredicateChecker` -> `NewTestPredicateCheckerWithCustomConfig` - latter narrows down meaning of the function better than former Signed-off-by: vadasambar <[email protected]> refactor: rename `GetSchedulerConfig` -> `ConfigFromPath` - `scheduler.ConfigFromPath` is shorter and feels less vague than `scheduler.GetSchedulerConfig` - move test config to a new package `test` under `config` package Signed-off-by: vadasambar <[email protected]> docs: add `TODO` for replacing code to parse scheduler config - with upstream function Signed-off-by: vadasambar <[email protected]>

Re-introduce asynchronous node deletion and clean node deletion logic.

Use fixed version of golang image

Bumps golang from 1.20.5 to 1.20.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Fix TestBinpackingLimiter flake

…akeNode-for-faulty-instance Fix: Do not inject fakeNode for instance which has errors on create

Generated by: ``` UPSTREAM_REF=v2.0.0 hack/update-vendor.sh ```

…addons-taint-ignored fix: don't clean `CriticalAddonsOnly` taint from template nodes

…out-controller Adapt limitations for Pods without controller

…custom-scheduler-config-poc feat: support custom scheduler config (without extenders)

…s-Update CA - AWS Cloudprovider OWNERS Update

Enable parallel drain by default.

…vertical-pod-autoscaler/builder/golang-1.20.6 Bump golang from 1.20.5 to 1.20.6 in /vertical-pod-autoscaler/builder

…chedule Add BigDarkClown to patch releases schedule

Update the `go:build` tag for missing cloud providers.

…file Fixed `go:build` tags for ovhcloud

Update Cluster Autoscaler vendor to K8s 1.28.0-beta.0

* pending_node_deletions * failed_gpu_scale_ups_total

…ackingFunc Add PostPackingFunc to be run at the end of the estimation logic

…remove-equal-tests Remove ChangeRequirements with `OrEqual` from EvictionControl enhancement proposal

Add a metric to observe nodes pending deletion after a finished scale-down phase

…aep-for-multi-container-pods Clarify Eviction Control for Pods with multiple Containers

Co-authored-by: Shubham <[email protected]>

Co-authored-by: Joachim <[email protected]>

…gpuInfo

Signed-off-by: AhmedGrati <[email protected]>

Add error code for invalid reservations to GCE client

Bumps golang from 1.20.6 to 1.20.7. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…d nodes

…vertical-pod-autoscaler/builder/golang-1.20.7 Bump golang from 1.20.6 to 1.20.7 in /vertical-pod-autoscaler/builder

Support ZeroOrMaxNodeScaling node groups when cleaning up unregistered nodes

Don't pass nil nodes to GetGpuInfoForMetrics

Fix nil pointer exception for case when node is nil while processing …

fix: balancer RBAC permission to update balancer status

chore(deps): update vendored hcloud-go to 2.0.0

…m-resources Add requirement for Custom Resources to VPA FAQ

Fix broken hyperlink

…cessing …"

…nil-pointer Revert "Fix nil pointer exception for case when node is nil while processing …"

…tion Signed-off-by: AhmedGrati <[email protected]>

…t creates

…irements API for KEP-4831: Control VPA eviction behavior based on scaling direction and resource

Clean up the NodeGroupConfigProcessor interface and remove the MaxNodeProvisioningTimeProvider interface.

Bumps golang from 1.20.7 to 1.21.0. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…vertical-pod-autoscaler/builder/golang-1.21.0 Bump golang from 1.20.7 to 1.21.0 in /vertical-pod-autoscaler/builder

…omment_update VPA: Update ResourcePolicy description and limit control README

…group_auto_discovery Fixed the hyperlink for Node group auto discovery.

Added s390x support

Set batch size to target size for atomically scaled groups

…theus-basic-auth [VPA] feat: add prometheus basic auth in the VPA recommender

…tions()

The default is to send a new request every 500ms, this will instead use an exponential backoff while waiting for the server the create.

Signed-off-by: ZhengSheng0524 <[email protected]>

…calls fix: scale down broken for providers not implementing NodeGroup.GetOptions()

GCE supports shared reservations where the reservation is in a different project than the project the cluster is in. Add GCE client method to get said reservations so autoscaling can support shared reservations.

Add fetch reservations in specific project

…p-consider Add details to consider section to VPA in-place updates AEP

Fix Doc with External gRPC

Allow using an externally created secret instead of using the one the Helm chart creates

fix: Broken links to testgrid dashboard

…ial-backoff feat(hetzner): use less requests while waiting for server create

Signed-off-by: AhmedGrati <[email protected]>

…proposal-5700 [addon-resizer] docs: add KEP to add nanny configuration automatic reload.

update RBAC to only use verbs that exist for the resources

…r-release-1.28-vendor-update CA - 1.28.0 k/k Vendor Update

…-v1.28.0

Co-authored-by: Rishabh Patel <[email protected]>

Commits on May 25, 2023

feat(*): add more metrics

qianlei90 committed May 25, 2023

Configuration menu

View commit details

Copy full SHA for fab8ec7

Browse repository at this point

Copy the full SHA

fab8ec7 View commit details

Browse the repository at this point in the history

Commits on Dec 18, 2023

Fix duplicate imports in IT

aaronfern committed Dec 18, 2023

Configuration menu

View commit details

Copy full SHA for fdf82e8

Browse repository at this point

Copy the full SHA

fdf82e8 View commit details

Browse the repository at this point in the history

Commits on Jan 22, 2024

re-add changes part of FORK-CHANGE

aaronfern committed Jan 22, 2024

Configuration menu

View commit details

Copy full SHA for 7bfb2bf

Browse repository at this point

Copy the full SHA

7bfb2bf View commit details

Browse the repository at this point in the history

Sync with upstream v1.28.0 #260

Sync with upstream v1.28.0 #260

Commits on May 25, 2023

Commits on May 29, 2023

Commits on May 30, 2023

Commits on May 31, 2023

Commits on Jun 2, 2023

Commits on Jun 5, 2023

Commits on Jun 6, 2023

Commits on Jun 7, 2023

Commits on Jun 8, 2023

Commits on Jun 9, 2023

Commits on Jun 12, 2023

Commits on Jun 13, 2023

Commits on Jun 14, 2023

Commits on Jun 15, 2023

Commits on Jun 16, 2023

Commits on Jun 17, 2023

Commits on Jun 20, 2023

Commits on Jun 21, 2023

Commits on Jun 22, 2023

Commits on Jun 23, 2023

Commits on Jun 26, 2023

Commits on Jun 27, 2023

Commits on Jun 28, 2023

Commits on Jun 29, 2023

Commits on Jun 30, 2023

Commits on Jul 3, 2023

Commits on Jul 4, 2023

Commits on Jul 5, 2023

Commits on Jul 6, 2023

Commits on Jul 8, 2023

Commits on Jul 10, 2023

Commits on Jul 11, 2023

Commits on Jul 12, 2023

Commits on Jul 13, 2023

Commits on Jul 14, 2023

Commits on Jul 17, 2023

Commits on Jul 18, 2023

Commits on Jul 19, 2023

Commits on Jul 20, 2023

Commits on Jul 21, 2023

Commits on Jul 24, 2023

Commits on Jul 25, 2023

Commits on Jul 26, 2023

Commits on Jul 27, 2023

Commits on Jul 28, 2023

Commits on Aug 1, 2023

Commits on Aug 2, 2023

Commits on Aug 3, 2023

Commits on Aug 4, 2023

Commits on Aug 5, 2023

Commits on Aug 7, 2023

Commits on Aug 8, 2023

Commits on Aug 9, 2023

Commits on Aug 10, 2023

Commits on Aug 11, 2023

Commits on Aug 15, 2023

Commits on Aug 16, 2023

Commits on Aug 17, 2023

Commits on Aug 18, 2023

Commits on Aug 21, 2023

Commits on Aug 22, 2023

Commits on Aug 23, 2023

Commits on Aug 24, 2023

Commits on Aug 28, 2023

Commits on Nov 24, 2023

Commits on Dec 11, 2023

Commits on Dec 18, 2023

Commits on Jan 22, 2024

Commits on Jan 26, 2024

Commits on Jan 27, 2024

Sync with upstream `v1.28.0` #260

Sync with upstream `v1.28.0` #260